Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Payment method - CashAppPay #2105

Merged
merged 34 commits into from
Jun 2, 2023
Merged

Payment method - CashAppPay #2105

merged 34 commits into from
Jun 2, 2023

Conversation

ribeiroguilherme
Copy link
Contributor

@ribeiroguilherme ribeiroguilherme commented Apr 7, 2023 •
edited
Loading

Summary

Adding support for CashAppPay payment method.

Highlights:

  • It works similar to GooglePay, as we need to load 3rd party SDK and then display its Pay button
  • It supports tokenization:
    • In case the merchant wants to display the 'Save payment method' checkbox, the property enableStoreDetails should be set
    • In case the merchant wants to tokenize without asking for consent, the property storePaymentMethod: true should be set

Tested scenarios

  • Unit tests
  • Tested using CashApp sandbox iOS app

@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2023 •
edited
Loading

Size Change: +8.68 kB (+1%)

Total Size: 1.04 MB

Filename Size Change
packages/lib/dist/adyen.js 276 kB +2.16 kB (+1%)
packages/lib/dist/cjs/index.js 237 kB +2.36 kB (+1%)
packages/lib/dist/es.modern/index.js 116 kB +1.81 kB (+2%)
packages/lib/dist/es/index.js 135 kB +2.35 kB (+2%)
ℹ️ View Unchanged
Filename Size
packages/lib/dist/es.modern/ar.js 6.17 kB
packages/lib/dist/es.modern/cs-CZ.js 5.59 kB
packages/lib/dist/es.modern/da-DK.js 5.06 kB
packages/lib/dist/es.modern/de-DE.js 5.47 kB
packages/lib/dist/es.modern/el-GR.js 7 kB
packages/lib/dist/es.modern/es-ES.js 5.15 kB
packages/lib/dist/es.modern/fi-FI.js 5.16 kB
packages/lib/dist/es.modern/fr-FR.js 5.26 kB
packages/lib/dist/es.modern/hr-HR.js 5.29 kB
packages/lib/dist/es.modern/hu-HU.js 5.55 kB
packages/lib/dist/es.modern/it-IT.js 5.14 kB
packages/lib/dist/es.modern/ja-JP.js 5.96 kB
packages/lib/dist/es.modern/ko-KR.js 5.59 kB
packages/lib/dist/es.modern/nl-NL.js 5.19 kB
packages/lib/dist/es.modern/no-NO.js 5.07 kB
packages/lib/dist/es.modern/pl-PL.js 5.55 kB
packages/lib/dist/es.modern/pt-BR.js 5.13 kB
packages/lib/dist/es.modern/pt-PT.js 5.25 kB
packages/lib/dist/es.modern/ro-RO.js 5.34 kB
packages/lib/dist/es.modern/ru-RU.js 6.5 kB
packages/lib/dist/es.modern/sk-SK.js 5.65 kB
packages/lib/dist/es.modern/sl-SI.js 5.22 kB
packages/lib/dist/es.modern/sv-SE.js 5.03 kB
packages/lib/dist/es.modern/zh-CN.js 5.41 kB
packages/lib/dist/es.modern/zh-TW.js 5.53 kB
packages/lib/dist/es/ar.js 6.17 kB
packages/lib/dist/es/cs-CZ.js 5.59 kB
packages/lib/dist/es/da-DK.js 5.06 kB
packages/lib/dist/es/de-DE.js 5.47 kB
packages/lib/dist/es/el-GR.js 7 kB
packages/lib/dist/es/es-ES.js 5.15 kB
packages/lib/dist/es/fi-FI.js 5.16 kB
packages/lib/dist/es/fr-FR.js 5.26 kB
packages/lib/dist/es/hr-HR.js 5.29 kB
packages/lib/dist/es/hu-HU.js 5.55 kB
packages/lib/dist/es/it-IT.js 5.14 kB
packages/lib/dist/es/ja-JP.js 5.96 kB
packages/lib/dist/es/ko-KR.js 5.59 kB
packages/lib/dist/es/nl-NL.js 5.19 kB
packages/lib/dist/es/no-NO.js 5.07 kB
packages/lib/dist/es/pl-PL.js 5.55 kB
packages/lib/dist/es/pt-BR.js 5.13 kB
packages/lib/dist/es/pt-PT.js 5.25 kB
packages/lib/dist/es/ro-RO.js 5.34 kB
packages/lib/dist/es/ru-RU.js 6.5 kB
packages/lib/dist/es/sk-SK.js 5.65 kB
packages/lib/dist/es/sl-SI.js 5.22 kB
packages/lib/dist/es/sv-SE.js 5.03 kB
packages/lib/dist/es/zh-CN.js 5.41 kB
packages/lib/dist/es/zh-TW.js 5.53 kB

compressed-size-action

@ribeiroguilherme ribeiroguilherme changed the title [WIP] CashAppPay [WIP] Payment method - CashAppPay Apr 11, 2023
@ribeiroguilherme ribeiroguilherme changed the title [WIP] Payment method - CashAppPay Payment method - CashAppPay May 25, 2023
@ribeiroguilherme ribeiroguilherme marked this pull request as ready for review May 25, 2023 14:18
@sponglord
Copy link
Contributor

sponglord commented May 25, 2023 •
edited
Loading

Even after I've dismissed the modal it continues to try and load the defaultlogo.jpg every x number of seconds.
So something isn't being torn town correctly

@sonarcloud
Copy link

sonarcloud bot commented Jun 1, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 4 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

73.9% 73.9% Coverage
0.0% 0.0% Duplication

@ribeiroguilherme ribeiroguilherme merged commit c2ec712 into main Jun 2, 2023
@ribeiroguilherme ribeiroguilherme deleted the feature/cashapp branch June 2, 2023 15:00
@github-actions github-actions bot mentioned this pull request Jun 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sponglord sponglord sponglord approved these changes

@marcperez marcperez Awaiting requested review from marcperez marcperez is a code owner

@pabloai pabloai Awaiting requested review from pabloai pabloai is a code owner

@m1aw m1aw Awaiting requested review from m1aw m1aw is a code owner

@jobsturm jobsturm Awaiting requested review from jobsturm

@longyulongyu longyulongyu Awaiting requested review from longyulongyu longyulongyu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ribeiroguilherme @sponglord